Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enables cors support for lambda proxy integrations for python #6477

Merged
merged 1 commit into from Jan 26, 2021

Conversation

akshbhu
Copy link
Contributor

@akshbhu akshbhu commented Jan 25, 2021

*Issue #5914 *

Description of changes:

  • enables cors support for lambda proxy integrations for python
  • Added tests for the same

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@akshbhu akshbhu requested a review from a team as a code owner January 25, 2021 19:25
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #6477 (9f4c6b9) into master (5789b26) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #6477    +/-   ##
========================================
  Coverage   57.34%   57.34%            
========================================
  Files         474      474            
  Lines       21671    21671            
  Branches     4307     4091   -216     
========================================
  Hits        12427    12427            
- Misses       8363     8383    +20     
+ Partials      881      861    -20     
Impacted Files Coverage Δ
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 35.29% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts 67.44% <0.00%> (ø)
.../amplify-util-mock/src/utils/lambda/loadMinimal.ts 0.00% <0.00%> (ø)
...graphql-transformer-core/src/TransformerContext.ts 25.09% <0.00%> (ø)
...mplify-appsync-simulator/src/resolvers/function.ts 15.38% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5789b26...9f4c6b9. Read the comment docs.

@akshbhu akshbhu linked an issue Jan 25, 2021 that may be closed by this pull request
@jhockett jhockett merged commit 44d1ce3 into aws-amplify:master Jan 26, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python template hello world function does not work
3 participants