Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Flutter Admin UI support #6516

Merged
merged 4 commits into from Feb 8, 2021
Merged

Added Flutter Admin UI support #6516

merged 4 commits into from Feb 8, 2021

Conversation

renebrandel
Copy link
Contributor

Description of changes:

  • Enables amplify pull --sandboxId <...> for Flutter projects

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@renebrandel renebrandel requested a review from a team as a code owner January 30, 2021 18:52
@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #6516 (3b7dad8) into master (b09ccf0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6516   +/-   ##
=======================================
  Coverage   57.27%   57.27%           
=======================================
  Files         479      479           
  Lines       21712    21712           
  Branches     4315     4315           
=======================================
  Hits        12435    12435           
  Misses       8396     8396           
  Partials      881      881           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b09ccf0...3b7dad8. Read the comment docs.

Copy link

@Ashish-Nanda Ashish-Nanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tested this and the amplify pull --sandboxId <...> works now.

@fjnoyp is testing this a bit more end to end.

@kaustavghosh06 can we get this merged tomorrow?

@fjnoyp
Copy link

fjnoyp commented Feb 4, 2021

The codegen models look good. ModelProvider.dart is not compiling because it's missing an implementation of "getModelTypeByModelName". Once that is resolved this should be good to go.

@edwardfoyle
Copy link
Member

Updated to include copying an empty amplifyconfiguration.dart file when initializing the flutter project. Wasn't sure what should be in the empty file so it has {} for now. Let me know what should be in there or update amplifyconfiguration.empty.dart in the PR with the expected contents

@phani-srikar
Copy link
Contributor

phani-srikar commented Feb 5, 2021

The codegen models look good. ModelProvider.dart is not compiling because it's missing an implementation of "getModelTypeByModelName". Once that is resolved this should be good to go.

To get the latest version of modelgen package for testing/debugging using yarn setup-dev, please update the dependency of amplify-codegen package on @aws-amplify/appsync-modelgen-plugin to the latest stable version example, currently it should be "@aws-amplify/appsync-modelgen-plugin": "^1.22.6",. Running yarn setup-dev then would update the lock file and use the latest modelgen. Note: Installing amplify CLI through npm or a self contained binary always fetches the latest version of dependencies and hence does not have this issue.

@yuth yuth merged commit d9ee44b into master Feb 8, 2021
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2022
@danielleadams danielleadams deleted the renbran/flutter-admin-ui branch November 21, 2022 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants