fix: pull issue with multi-env notifications #6475 #6525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix notificaiton category multi-env handling - fix to ask for `API key` for FCM on `remove notification` command - add E2E for notification testing
Codecov Report
@@ Coverage Diff @@
## master #6525 +/- ##
==========================================
- Coverage 56.84% 56.42% -0.43%
==========================================
Files 487 430 -57
Lines 22076 21124 -952
Branches 4414 4233 -181
==========================================
- Hits 12550 11919 -631
+ Misses 8649 8393 -256
+ Partials 877 812 -65
Continue to review full report at Codecov.
|
edwardfoyle
approved these changes
Feb 1, 2021
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#6475
Description of changes:
API keyfor FCM onremove notificationcommandBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.