-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #5765 add support for android studio, xcode #6527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Codecov Report
@@ Coverage Diff @@
## master #6527 +/- ##
==========================================
- Coverage 56.84% 56.42% -0.43%
==========================================
Files 487 430 -57
Lines 22076 21124 -952
Branches 4414 4233 -181
==========================================
- Hits 12550 11919 -631
+ Misses 8649 8393 -256
+ Partials 877 812 -65
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few small things
packages/amplify-cli/src/extensions/amplify-helpers/open-editor.ts
Outdated
Show resolved
Hide resolved
packages/amplify-cli/src/extensions/amplify-helpers/open-editor.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One nit, there is a PR #6503 to centralize the open
method. May be you can use the method from that
Do not merge until this gets into our dependency: sindresorhus/env-editor#11 Then I can remove the extra part from our code for Xcode UPDATE: env-editor has xcode support, PR updated. |
https://github.com/sindresorhus/env-editor/releases/tag/v0.5.0 |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
fix: #5765
Description of changes:
This PR adds support for Android Studio and Xcode as selected editor. Also when a selected editor's binary was not found then a fallback question is added to open the given file with the OS associated default editor instead.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.