Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #5765 add support for android studio, xcode #6527

Merged
merged 5 commits into from
Mar 2, 2021
Merged

fix: #5765 add support for android studio, xcode #6527

merged 5 commits into from
Mar 2, 2021

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Feb 1, 2021

Issue #, if available:

fix: #5765

Description of changes:

This PR adds support for Android Studio and Xcode as selected editor. Also when a selected editor's binary was not found then a fallback question is added to open the given file with the OS associated default editor instead.

image

image

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@attilah attilah requested a review from yuth February 1, 2021 19:23
@attilah attilah requested a review from a team as a code owner February 1, 2021 19:23
Copy link
Contributor

@jamesonwilliams jamesonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #6527 (1e900e3) into master (59d66fe) will decrease coverage by 0.42%.
The diff coverage is 11.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6527      +/-   ##
==========================================
- Coverage   56.84%   56.42%   -0.43%     
==========================================
  Files         487      430      -57     
  Lines       22076    21124     -952     
  Branches     4414     4233     -181     
==========================================
- Hits        12550    11919     -631     
+ Misses       8649     8393     -256     
+ Partials      877      812      -65     
Impacted Files Coverage Δ
.../amplify-category-notifications/lib/channel-FCM.js 0.00% <0.00%> (ø)
...fy-category-notifications/lib/multi-env-manager.js 0.00% <0.00%> (ø)
...extensions/amplify-helpers/get-frontend-plugins.ts 7.69% <0.00%> (-8.98%) ⬇️
...ackages/amplify-cli/src/init-steps/s9-onFailure.ts 50.00% <ø> (+7.14%) ⬆️
packages/amplify-cli/src/index.ts 42.38% <33.33%> (-1.19%) ⬇️
...src/extensions/amplify-helpers/editor-selection.ts 44.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0803d1...1e900e3. Read the comment docs.

Copy link
Member

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few small things

Copy link
Contributor

@yuth yuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nit, there is a PR #6503 to centralize the open method. May be you can use the method from that

@attilah attilah changed the title fix: #5765 add support for android studio, xcode DO NOT MERGE: fix: #5765 add support for android studio, xcode Feb 2, 2021
@attilah
Copy link
Contributor Author

attilah commented Feb 2, 2021

Do not merge until this gets into our dependency: sindresorhus/env-editor#11

Then I can remove the extra part from our code for Xcode

UPDATE: env-editor has xcode support, PR updated.

@sindresorhus
Copy link

Do not merge until this gets into our dependency: sindresorhus/env-editor#11

https://github.com/sindresorhus/env-editor/releases/tag/v0.5.0

@attilah attilah changed the title DO NOT MERGE: fix: #5765 add support for android studio, xcode fix: #5765 add support for android studio, xcode Feb 8, 2021
@attilah attilah merged commit 092afa2 into aws-amplify:master Mar 2, 2021
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting intellij should also fall back to android studio as an editor
6 participants