Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-appsync-simulator): remove graphql-scalars dependency #6680

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 19, 2021

Issue #, if available: #6656

Description of changes:
This commit removes the dependency on graphql-scalars and adds the implementations for the AWSEmail and AWSURL scalars.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This commit removes the dependency on graphql-scalars and adds
the implementations for the AWSEmail and AWSURL scalars.

Fixes: #6656
@cjihrig cjihrig requested a review from a team as a code owner February 19, 2021 14:47
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #6680 (9bce3fe) into master (38dab98) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6680   +/-   ##
=======================================
  Coverage   56.71%   56.72%           
=======================================
  Files         484      484           
  Lines       22006    22025   +19     
  Branches     4395     4401    +6     
=======================================
+ Hits        12481    12493   +12     
- Misses       8648     8655    +7     
  Partials      877      877           
Impacted Files Coverage Δ
...sync-simulator/src/schema/appsync-scalars/index.ts 45.05% <66.66%> (+4.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38dab98...9bce3fe. Read the comment docs.

@edwardfoyle edwardfoyle merged commit f12c994 into aws-amplify:master Feb 26, 2021
@cjihrig cjihrig deleted the email branch March 13, 2021 15:55
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to start API Mock endpoint Error: Duplicate schema type name EmailAddress
3 participants