fix(cli): add defensive coding to isContainersEnabled() #6758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6758 +/- ##
=======================================
Coverage 56.84% 56.84%
=======================================
Files 487 487
Lines 22076 22076
Branches 4414 4414
=======================================
Hits 12550 12550
Misses 8649 8649
Partials 877 877 Continue to review full report at Codecov.
|
attilah
approved these changes
Mar 2, 2021
|
|
||
| return false; | ||
| const projectConfig = context.amplify.getProjectConfig(); | ||
| return projectConfig?.[projectConfig?.frontend]?.config?.ServerlessContainers ?? false; |
There was a problem hiding this comment.
IMHO the ? after projectConfig inside the brackets is extra, because of the LTR eval.
This commit adds optional chaining and nullish coalescing to the isContainersEnabled() function. It also stores the project config in a variable instead of parsing it multiple times.
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #6757
Description of changes:
This commit adds optional chaining and nullish coalescing to the
isContainersEnabled()function. It also stores the project config in a variable instead of parsing it multiple times.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.