fix(amplify-provider-awscloudformation): specify 127.0.0.1 as hostname #6780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI uses express server in `amplify-provider-awscloudformation` to listen to POST request from Admin UI login page when `amplify configure`. The default of the hostname is localhost, 0.0.0.0 and 127.0.0.1 on macOS, but Ubuntu on WSL on Windows uses only localhost by default. Since 127.0.0.1 is used in Admin UI, we should specify 127.0.0.1 as the hostname in CLI so that CLI can finish `amplify configure`. Fixes: aws-amplify#6779 Fixes: aws-amplify/amplify-studio#134
Codecov Report
@@ Coverage Diff @@
## master #6780 +/- ##
==========================================
+ Coverage 56.45% 56.50% +0.05%
==========================================
Files 430 430
Lines 21138 21140 +2
Branches 4237 4237
==========================================
+ Hits 11933 11946 +13
+ Misses 8392 8381 -11
Partials 813 813
Continue to review full report at Codecov.
|
jhockett
reviewed
Mar 3, 2021
packages/amplify-provider-awscloudformation/src/utils/admin-login-server.ts
Outdated
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/__tests__/utils/admin-login-server.test.ts
Show resolved
Hide resolved
yuth
approved these changes
Mar 3, 2021
4 tasks
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI uses express server in
amplify-provider-awscloudformationto listen to POST request from Admin UI login page whenamplify configure. The default of the hostname is localhost, 0.0.0.0 and 127.0.0.1 on macOS, but Ubuntu on WSL on Windows uses the only localhost by default. Since 127.0.0.1 seems to be coded in Admin UI, we should specify 127.0.0.1 as the hostname in CLI so that CLI can finishamplify configure.Fixes: #6779
Fixes: aws-amplify/amplify-studio#134
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.