fix: add sharedId in externalAuthEnable()
#7315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
commented
May 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #7315 +/- ##
=======================================
Coverage 52.63% 52.63%
=======================================
Files 511 511
Lines 25895 25893 -2
Branches 5052 5052
=======================================
- Hits 13630 13629 -1
+ Misses 11292 11291 -1
Partials 973 973
Continue to review full report at Codecov.
|
This commit updates externalAuthEnable() to include the auth sharedId when creating an auth resource. The sharedId is given the lowest priority in the authProps object so that it will not overwrite any previously existing sharedId. It also uses the sharedId from cognito-defaults for consistency. This change prevents the creation of "snsundefined" roles.
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v4.51.3 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.51.3. |
cjihrig
added a commit
to ctjlewis/amplify-cli
that referenced
this pull request
Jul 12, 2021
This commit updates externalAuthEnable() to include the auth sharedId when creating an auth resource. The sharedId is given the lowest priority in the authProps object so that it will not overwrite any previously existing sharedId. It also uses the sharedId from cognito-defaults for consistency. This change prevents the creation of "snsundefined" roles. Co-authored-by: Colin Ihrig <colihrig@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit updates
externalAuthEnable()to include the authsharedIdwhen creating an auth resource. ThesharedIdis given the lowest priority in theauthPropsobject so that it will not overwrite any previously existingsharedId. It also uses thesharedIdfromcognito-defaultsfor consistency. This change prevents the creation ofsnsundefinedroles.Issue #, if available
N/A
Description of how you validated changes
Manual testing - create a new project, add a REST API with restricted access
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.