Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added required parameters in Email notifications channel #7552

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

akshbhu
Copy link
Contributor

@akshbhu akshbhu commented Jun 18, 2021

Description of changes

FromAddress and Identity are required parameters in UpdateEmailChannel() sdk call which were missing in current Implementation

Issue #7464

Description of how you validated changes

  • Tested manually

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@akshbhu akshbhu requested a review from a team as a code owner June 18, 2021 21:47
@codecov-commenter
Copy link

Codecov Report

Merging #7552 (486f46c) into master (312eec3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7552      +/-   ##
==========================================
- Coverage   52.76%   52.76%   -0.01%     
==========================================
  Files         523      523              
  Lines       26157    26158       +1     
  Branches     5119     5119              
==========================================
  Hits        13802    13802              
- Misses      11385    11386       +1     
  Partials      970      970              
Impacted Files Coverage Δ
...mplify-category-notifications/lib/channel-Email.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312eec3...486f46c. Read the comment docs.

@edwardfoyle edwardfoyle merged commit e3e51f5 into aws-amplify:master Jun 22, 2021
@cjihrig cjihrig linked an issue Jun 24, 2021 that may be closed by this pull request
4 tasks
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v5.0.2 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.0.2.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Jun 24, 2021
cjihrig pushed a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing required key 'FromAddress' in params.EmailChannelRequest
5 participants