fix(amplify-provider-awscloudformation): display mfa prompt #7866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, the ora spinner is blocks the mfa prompt from appearing to the user. this commit makes sure a spinner is not running before prompting for mfa, then continues the spinner afterwords if required.
cjihrig
approved these changes
Aug 4, 2021
jhockett
pushed a commit
that referenced
this pull request
Aug 25, 2021
currently, the ora spinner is blocks the mfa prompt from appearing to the user. this commit makes sure a spinner is not running before prompting for mfa, then continues the spinner afterwords if required.
|
@johnpc this change appears to be causing E2E test failures: https://23881-145880460-gh.circle-artifacts.com/0/~/repo/packages/amplify-e2e-tests/amplify-e2e-reports/index.html Are you able to fix this, or should I revert this change? |
cjihrig
added a commit
that referenced
this pull request
Aug 27, 2021
|
👋 Hi, this pull request was referenced in the v5.4.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.4.0. |
github-actions
bot
added
the
referenced-in-release
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
…ify#7866) currently, the ora spinner is blocks the mfa prompt from appearing to the user. this commit makes sure a spinner is not running before prompting for mfa, then continues the spinner afterwords if required.
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
…ws-amplify#7866)" (aws-amplify#8054) This reverts commit 8947b18. The original commit was causing E2E test failures. Co-authored-by: Colin Ihrig <colihrig@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
currently, the ora spinner is blocks the mfa prompt from appearing to the user.
Screen.Recording.2021-08-03.at.2.26.14.PM.mov
this commit makes sure a spinner is not running before prompting for mfa, then continues the spinner afterwords if required.
Screen.Recording.2021-08-03.at.2.26.58.PM.mov
Issue #, if available
fix #7848
Description of how you validated changes
Manually set up mfa and ran
amplify push. See before and after screen recordings.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.