Revert "fix: function names are made to match package.json's format (#7988) #8051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #8051 +/- ##
=======================================
Coverage 54.13% 54.13%
=======================================
Files 657 657
Lines 37488 37488
Branches 7698 7698
=======================================
Hits 20295 20295
Misses 16353 16353
Partials 840 840
Continue to review full report at Codecov.
|
jhockett
approved these changes
Aug 27, 2021
|
👋 Hi, this pull request was referenced in the v5.4.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.4.0. |
github-actions
bot
added
the
referenced-in-release
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
…ws-amplify#7988)" (aws-amplify#8051) This reverts commit 25689dd. Reverting as this breaks an E2E test, and if released, this could break customers' automated workflows. Co-authored-by: Colin Ihrig <colihrig@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This reverts commit 25689dd.
Reverting as this breaks an E2E test, and if released, this could
break customers' automated workflows. I'm also not sure that this needs to be enforced for anything but Node.js functions.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.