Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-category-function): specify UTC tz when selecting start time #8053

Merged
merged 1 commit into from Sep 9, 2021

Conversation

danielleadams
Copy link
Member

@danielleadams danielleadams commented Aug 27, 2021

Description of changes

Adds 'in UTC' when selecting a function start time or scheduled recurring time.

Issue #, if available

Fixes: #8027

Description of how you validated changes

Locally built the cli and tested by adding and updating a function.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danielleadams danielleadams requested a review from a team as a code owner August 27, 2021 15:36
@codecov-commenter
Copy link

Codecov Report

Merging #8053 (bd1a889) into master (f7e62df) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8053   +/-   ##
=======================================
  Coverage   54.13%   54.13%           
=======================================
  Files         657      657           
  Lines       37488    37488           
  Branches     7698     7698           
=======================================
  Hits        20295    20295           
  Misses      16353    16353           
  Partials      840      840           
Impacted Files Coverage Δ
...ovider-utils/awscloudformation/utils/cronHelper.ts 19.51% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e62df...bd1a889. Read the comment docs.

Copy link
Contributor

@akshbhu akshbhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@attilah attilah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhockett jhockett merged commit 5e3d69a into aws-amplify:master Sep 9, 2021
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Sep 14, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v5.6.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.6.0.

marcvberg pushed a commit to marcvberg/amplify-cli that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify timezone for Lambda recurring schedule
5 participants