fix(amplify-category-auth): handle undefined aliasattributes #8222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8222 +/- ##
=======================================
Coverage 54.42% 54.42%
=======================================
Files 663 663
Lines 37871 37871
Branches 7786 7786
=======================================
Hits 20611 20611
Misses 16415 16415
Partials 845 845
Continue to review full report at Codecov.
|
Closed
4 tasks
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v6.0.1 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v6.0.1. |
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
amplify update authis currently broken for CLI users that created auth before v5.2.0, because generatedparameters.jsonfile does not containaliasAttributeskey. This PR adds handling for the undefined alias attributes case, fixingamplify update authfor that caseIssue #, if available
#8221
Description of how you validated changes
Created auth using v5.1.0
Updated auth using v6 (including this change)
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.