Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-category-auth): switching to social providers with user pools instead of identity pools #8308

Merged
merged 1 commit into from Oct 26, 2021
Merged

Conversation

lazpavel
Copy link
Contributor

@lazpavel lazpavel commented Sep 29, 2021

Description of changes

  • provide user pool social providers instead of identity pools social providers for in the frontendConfig
  • fixed parameters.json missing frontendConfig on import auth
  • split login mechanisms into social providers and username attributes (+ignore alias attributes for front end config)

Description of how you validated changes

  • manual testing
  • tested existing e2e test
  • updated unit test
  • yarn test passes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lazpavel lazpavel requested a review from a team as a code owner September 29, 2021 20:48
@lazpavel lazpavel marked this pull request as draft October 14, 2021 20:48
@lazpavel lazpavel marked this pull request as ready for review October 19, 2021 00:02
@ammarkarachi ammarkarachi merged commit 0c82fe3 into aws-amplify:master Oct 26, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v6.4.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v6.4.0.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Nov 11, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.3.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants