Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graphql-relational-schema-transformer): has-many transformer update filter/condition inputs #8565

Merged
merged 1 commit into from Oct 30, 2021
Merged

fix(graphql-relational-schema-transformer): has-many transformer update filter/condition inputs #8565

merged 1 commit into from Oct 30, 2021

Conversation

lazpavel
Copy link
Contributor

@lazpavel lazpavel commented Oct 26, 2021 •
edited

Description of changes

  • adds GSI index link field in the related type for has many directive
  • adds GSI index field to Filter and Condition Inputs
  • updates hasMany directive with the GSI index name

Description of how you validated changes

  • tested local android datastore application before and after changes
  • tested local iOS datastore application before and after changes
  • tested local javascript datastore application before and after changes
  • tested local flutter datastore application before and after changes
  • yarn test passes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lazpavel lazpavel requested a review from a team as a code owner October 26, 2021 21:47
@lazpavel lazpavel marked this pull request as draft October 26, 2021 22:20
@lazpavel lazpavel marked this pull request as ready for review October 27, 2021 20:42
sundersc
sundersc approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@sundersc sundersc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lazpavel lazpavel merged commit 9f5570b into aws-amplify:master Oct 30, 2021
ammarkarachi pushed a commit to ammarkarachi/amplify-cli that referenced this pull request Nov 3, 2021
@lazpavel
fix(graphql-relational-schema-transformer): has-many transformer upda…
3228699 
…te filter/condition inputs (aws-amplify#8565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundersc sundersc sundersc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lazpavel @sundersc