Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update auth vnext validation to use private for oidc #8606

Merged
merged 1 commit into from Oct 31, 2021

Conversation

SwaySway
Copy link
Contributor

Description of changes

  • update validation to allow private to work for oidc
  • updated unit test to verify

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SwaySway SwaySway requested a review from a team as a code owner October 31, 2021 01:01
Copy link
Contributor

@lazpavel lazpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #8606 (9715ac9) into master (bd435e2) will increase coverage by 1.21%.
The diff coverage is 56.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8606      +/-   ##
==========================================
+ Coverage   55.92%   57.13%   +1.21%     
==========================================
  Files         695      728      +33     
  Lines       38881    41174    +2293     
  Branches     7871     8441     +570     
==========================================
+ Hits        21743    23524    +1781     
- Misses      16343    16838     +495     
- Partials      795      812      +17     
Impacted Files Coverage Δ
...fy-appsync-simulator/src/schema/directives/auth.ts 18.42% <ø> (ø)
...ppsync-simulator/src/utils/auth-helpers/helpers.ts 80.95% <ø> (ø)
...egory-api/src/provider-utils/supported-services.ts 100.00% <ø> (ø)
packages/amplify-category-auth/src/index.js 15.74% <0.00%> (ø)
...ider-utils/awscloudformation/assets/string-maps.js 86.20% <ø> (ø)
...auth/src/provider-utils/awscloudformation/index.js 3.90% <0.00%> (ø)
...ils/awscloudformation/service-walkthrough-types.ts 100.00% <ø> (ø)
...udformation/service-walkthroughs/auth-questions.js 3.33% <0.00%> (ø)
...s/amplify-category-geo/src/commands/geo/console.ts 53.84% <0.00%> (+3.84%) ⬆️
...amplify-cli-core/src/feature-flags/featureFlags.ts 83.62% <ø> (ø)
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d50df0...9715ac9. Read the comment docs.

@SwaySway SwaySway merged commit 8e659a1 into aws-amplify:master Oct 31, 2021
@SwaySway SwaySway deleted the vnext-oidc-validation branch October 31, 2021 20:16
ammarkarachi pushed a commit to ammarkarachi/amplify-cli that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants