fix(amplify-category-api): change auth directive type and fix codegen bug #8639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8639 +/- ##
=======================================
Coverage 56.97% 56.97%
=======================================
Files 741 741
Lines 41707 41707
Branches 8537 8537
=======================================
Hits 23764 23764
Misses 17122 17122
Partials 821 821
Continue to review full report at Codecov.
|
| @@ -15,7 +15,7 @@ export async function showSandboxModePrompts(context: $TSContext): Promise<any> | |||
| printer.info( | |||
There was a problem hiding this comment.
nit: could use printer.warn here. If you switch it, remove the leading warn internally
| for (let i = 0; i < authModes.length; i++) { | ||
| const mode = authModes[i]; | ||
|
|
||
| if (mode !== 'API_KEY' && mode !== 'AMAZON_COGNITO_USER_POOLS' && mode !== 'AWS_IAM' && mode !== 'OPENID_CONNECT' && mode !== 'AWS_LAMBDA') { | ||
| if ( | ||
| mode !== 'API_KEY' && | ||
| mode !== 'AMAZON_COGNITO_USER_POOLS' && | ||
| mode !== 'AWS_IAM' && | ||
| mode !== 'OPENID_CONNECT' && | ||
| mode !== 'AWS_LAMBDA' | ||
| ) { | ||
| throw new Error(`Invalid auth mode ${mode}`); | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: I know this was just a formatting change, but this could be simplified a bit to:
const allowedAuthModes = ['API_KEY', 'AWS_IAM', ...];
const invalidMode = authModes.find(mode => !allowedAuthModes.includes(mode));
if (!!invalidMode) {
throw new Error(`Invalid auth mode ${mode}`)
}
There was a problem hiding this comment.
If we're going to go this route, please hoist the array out of the function so that the same array can be reused. It might also make sense to use a Set instead of an array (not sure if there are enough elements to make it worth it though).
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v6.4.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v6.4.0. |
Description of changes
changes the global authorization type to use
AuthRule-> this also fixes the reportedamplify codegen modelsbug.Description of how you validated changes
Changed unit tests, tested locally, added codegen models to the e2e tests.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.