Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use output when looking up relational related type index #8657

Merged
merged 1 commit into from Nov 4, 2021
Merged

fix: use output when looking up relational related type index #8657

merged 1 commit into from Nov 4, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 4, 2021

Description of changes

This allows the implicitly added 'id' field to be properly used.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This allows the implicitly added 'id' field to be properly used.
@cjihrig cjihrig requested a review from a team as a code owner November 4, 2021 00:01
@SwaySway
Copy link
Contributor

SwaySway commented Nov 4, 2021

lgtm pending ci

@codecov-commenter
Copy link

Codecov Report

Merging #8657 (d61bddd) into master (70547ad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8657   +/-   ##
=======================================
  Coverage   56.88%   56.88%           
=======================================
  Files         756      756           
  Lines       42238    42239    +1     
  Branches     8649     8649           
=======================================
+ Hits        24027    24028    +1     
  Misses      17390    17390           
  Partials      821      821           
Impacted Files Coverage Δ
...mplify-graphql-relational-transformer/src/utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70547ad...d61bddd. Read the comment docs.

@cjihrig cjihrig requested a review from yuth November 4, 2021 00:28
@yuth yuth merged commit 1f5dd5c into aws-amplify:master Nov 4, 2021
@cjihrig cjihrig deleted the bugfix branch November 4, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants