Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Has many connected field #8700

Merged
merged 1 commit into from Nov 6, 2021
Merged

Has many connected field #8700

merged 1 commit into from Nov 6, 2021

Conversation

lazpavel
Copy link
Contributor

@lazpavel lazpavel commented Nov 6, 2021

Description of changes

  • updates connected field for has many

Description of how you validated changes

  • yarn test passes
  • manual testing for models generation in all platforms (js/android/ios/flutter)
  • manual testing a full datastore app with ios

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lazpavel lazpavel requested a review from a team as a code owner November 6, 2021 17:28
cjihrig
cjihrig approved these changes Nov 6, 2021
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the second commit (since the first one is from another PR). LGTM

@lazpavel lazpavel merged commit cc21d4d into aws-amplify:master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lazpavel @cjihrig