Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vtl list utils & update model test scenarios #8701

Merged
merged 1 commit into from Nov 7, 2021

Conversation

SwaySway
Copy link
Contributor

@SwaySway SwaySway commented Nov 6, 2021

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SwaySway SwaySway requested a review from a team as a code owner November 6, 2021 17:55
@codecov-commenter
Copy link

Codecov Report

Merging #8701 (cd8fb5c) into master (14921fe) will increase coverage by 0.00%.
The diff coverage is 79.16%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8701   +/-   ##
=======================================
  Coverage   57.15%   57.15%           
=======================================
  Files         728      728           
  Lines       41195    41209   +14     
  Branches     8445     8453    +8     
=======================================
+ Hits        23546    23555    +9     
- Misses      16837    16842    +5     
  Partials      812      812           
Impacted Files Coverage Δ
...ppsync-simulator/src/utils/auth-helpers/helpers.ts 80.95% <ø> (ø)
...ppsync-simulator/src/utils/graphql-runner/index.ts 100.00% <ø> (ø)
...es/amplify-appsync-simulator/src/velocity/index.ts 73.13% <28.57%> (-5.56%) ⬇️
...-appsync-simulator/src/velocity/util/list-utils.ts 100.00% <100.00%> (ø)
packages/amplify-util-mock/src/velocity/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14921fe...cd8fb5c. Read the comment docs.

@ammarkarachi
Copy link
Contributor

catthumbs

@cjihrig cjihrig merged commit 402cd9b into aws-amplify:master Nov 7, 2021
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Nov 11, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v6.4.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v6.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants