Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override http datasource logical IDs #8714

Merged
merged 1 commit into from Nov 7, 2021
Merged

fix: override http datasource logical IDs #8714

merged 1 commit into from Nov 7, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 7, 2021

Description of changes

This commit overrides the logical IDs of http datasources
created by the gql v2 transformer to prevent issues when
migrating from v1. It also renames the @http stack to be
consistent with v1.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This commit overrides the logical IDs of http datasources
created by the gql v2 transformer to prevent issues when
migrating from v1. It also renames the @http stack to be
consistent with v1.
@cjihrig cjihrig requested a review from lazpavel November 7, 2021 22:21
@cjihrig cjihrig requested a review from a team as a code owner November 7, 2021 22:21
Copy link
Contributor

@lazpavel lazpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #8714 (a161af4) into master (f798bbf) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8714      +/-   ##
==========================================
- Coverage   56.92%   56.91%   -0.01%     
==========================================
  Files         756      756              
  Lines       42231    42233       +2     
  Branches     8651     8651              
==========================================
  Hits        24038    24038              
- Misses      17372    17374       +2     
  Partials      821      821              
Impacted Files Coverage Δ
...ify-graphql-transformer-core/src/transform-host.ts 24.79% <0.00%> (-0.42%) ⬇️
...l-http-transformer/src/graphql-http-transformer.ts 98.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f798bbf...a161af4. Read the comment docs.

@cjihrig cjihrig merged commit 81cc461 into aws-amplify:master Nov 7, 2021
@cjihrig cjihrig deleted the http-ds branch November 7, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants