Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transformer version #9092

Merged
merged 3 commits into from Nov 26, 2021
Merged

Conversation

akshbhu
Copy link
Contributor

@akshbhu akshbhu commented Nov 25, 2021

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@akshbhu akshbhu requested a review from a team as a code owner November 25, 2021 21:48
Copy link
Member

@danielleadams danielleadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the asyncs/awaits pass build 👍🏼

Copy link

@yppartyk yppartyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #9092 (8c53705) into master (5859e93) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9092   +/-   ##
=======================================
  Coverage   55.39%   55.39%           
=======================================
  Files         885      885           
  Lines       50137    50141    +4     
  Branches    10812    10814    +2     
=======================================
+ Hits        27771    27774    +3     
- Misses      20313    20314    +1     
  Partials     2053     2053           
Impacted Files Coverage Δ
...mation/service-walkthroughs/appSync-walkthrough.ts 15.33% <0.00%> (ø)
packages/amplify-cli/src/commands/status.ts 48.00% <0.00%> (ø)
...rc/graphql-transformer/transform-graphql-schema.ts 15.53% <25.00%> (ø)
...-awscloudformation/src/transform-graphql-schema.ts 17.78% <50.00%> (+0.67%) ⬆️
...lify-cli-core/src/utils/gql-transformer-version.ts 16.66% <100.00%> (ø)
.../amplify-util-mock/src/api/lambda-arn-to-config.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5859e93...8c53705. Read the comment docs.

@akshbhu akshbhu changed the title fix: [Dont merge ]transformer version fix: transformer version Nov 26, 2021
@danielleadams danielleadams merged commit acfa82c into aws-amplify:master Nov 26, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.5.3 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.5.3.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants