fix: remove functionName from transform-host lambdas #9491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @searchable and @predictions directives create a Lambda function via context.api.host.addLambdaFunction(). This commit updates addLambdaFunction() to not set the optional functionName in the CFN. This lets CFN generate a unique name. The mock functionality also needed to be updated because mock expects all Lambdas to have this optional property. If the CFN does not contain a functionName, fall back to the resource name.
Codecov Report
@@ Coverage Diff @@
## master #9491 +/- ##
=======================================
Coverage 56.13% 56.13%
=======================================
Files 902 902
Lines 50632 50632
Branches 10944 10945 +1
=======================================
Hits 28422 28422
Misses 20179 20179
Partials 2031 2031
Continue to review full report at Codecov.
|
|
LGTM |
|
Waiting on this to be able to deploy to production |
johnpc
approved these changes
Jan 13, 2022
lazpavel
approved these changes
Jan 13, 2022
|
Can this please be deployed to npm ASAP? It is blocking deployments to production, and downgrading is not a 100% error-proof workaround |
|
👋 Hi, this pull request was referenced in the v7.6.10 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.10. |
github-actions
bot
added
the
referenced-in-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@searchableand@predictionsdirectives create a Lambdafunction via
context.api.host.addLambdaFunction(). This commitupdates
addLambdaFunction()to not set the optionalfunctionNamein the CFN. This lets CFN generate a unique name.
The mock functionality also needed to be updated because mock
expects all Lambdas to have this optional property. If the CFN
does not contain a
functionName, fall back to the resource name.Fixes: #9480