Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: graphql-transformer-migrator add modelgen flag after v2 migrate #9565

Merged
merged 6 commits into from
Feb 11, 2022

Conversation

marcvberg
Copy link
Contributor

Fixes #9503

Description of changes

Sets the modelgen plugin flag on migration to true so that erroneous warnings are not thrown about missing connections

Issue #, if available

Description of how you validated changes

Ran a local migration

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@marcvberg marcvberg requested a review from a team as a code owner January 19, 2022 22:02
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR has changed a good bit since it's original version, can you include some tests as well.

Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
@yuth yuth merged commit 9bff4ae into aws-amplify:master Feb 11, 2022
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Feb 15, 2022
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.6.20 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amplify codegaen models - after migration to V2
4 participants