-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: graphql-transformer-migrator add modelgen flag after v2 migrate #9565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Jan 19, 2022
lazpavel
approved these changes
Jan 19, 2022
cjihrig
suggested changes
Jan 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR has changed a good bit since it's original version, can you include some tests as well.
packages/amplify-graphql-transformer-migrator/src/state-migrator.ts
Outdated
Show resolved
Hide resolved
packages/amplify-graphql-transformer-migrator/src/state-migrator.ts
Outdated
Show resolved
Hide resolved
packages/amplify-graphql-transformer-migrator/src/state-migrator.ts
Outdated
Show resolved
Hide resolved
packages/amplify-graphql-transformer-migrator/src/state-migrator.ts
Outdated
Show resolved
Hide resolved
packages/amplify-graphql-transformer-migrator/src/state-migrator.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
cjihrig
approved these changes
Feb 4, 2022
…-cli into migration-modelgen-fix
github-actions
bot
added
the
referenced-in-release
Issues referenced in a published release changelog
label
Feb 15, 2022
👋 Hi, this pull request was referenced in the v7.6.20 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9503
Description of changes
Sets the modelgen plugin flag on migration to true so that erroneous warnings are not thrown about missing connections
Issue #, if available
Description of how you validated changes
Ran a local migration
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.