Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow pinpoint category removal after manual deletion #9691

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

johnpc
Copy link
Contributor

@johnpc johnpc commented Feb 3, 2022

Description of changes

This PR fixes an issue where, if a Pinpoint project is deleted manually via AWS Console, the notifications category could not be removed from the amplify project. It accomplishes this by treating a NotFoundException on deletion as a successful deletion.

Issue #, if available

#9036

Description of how you validated changes

amplify add notifications && amplify push
delete pinpoint manually
amplify remove notifications && amplify push
# note that everything seems to work on AWS console/amplify status
amplify pull/push no longer recreates the notifications category.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@johnpc johnpc requested a review from a team as a code owner February 3, 2022 17:59
@codecov-commenter
Copy link

Codecov Report

Merging #9691 (9ce67a2) into master (4a87373) will decrease coverage by 0.04%.
The diff coverage is 31.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9691      +/-   ##
==========================================
- Coverage   52.93%   52.89%   -0.05%     
==========================================
  Files         829      830       +1     
  Lines       45865    45957      +92     
  Branches     9789     9815      +26     
==========================================
+ Hits        24279    24308      +29     
- Misses      19581    19634      +53     
- Partials     2005     2015      +10     
Impacted Files Coverage Δ
...mplify-category-notifications/lib/channel-Email.js 0.00% <0.00%> (ø)
...lify-category-notifications/lib/pinpoint-helper.js 0.00% <0.00%> (ø)
...amplify-cli-core/src/feature-flags/featureFlags.ts 80.83% <ø> (ø)
...c/extensions/amplify-helpers/auth-notifications.ts 34.14% <34.14%> (ø)
...l-auth-transformer/src/graphql-auth-transformer.ts 89.62% <50.00%> (ø)
packages/graphql-transformer-core/src/index.ts 97.29% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ff6fe8...9ce67a2. Read the comment docs.

@ammarkarachi ammarkarachi merged commit dc218d4 into master Feb 3, 2022
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.6.19 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.19.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Feb 10, 2022
@evcodes evcodes deleted the pinpoint-delete branch February 18, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants