fix: get the defaultEditor value from the localEnvInfo context variable

[flozender]

Description of changes

Get the default editor value from the context variable when the local-env-info.json file has not been created yet.

Issue #, if available

Closes #8356

Description of how you validated changes

The default editor now shows up on running amplify configure project since the local-env-info.json file now has the defaultEditor key. yarn test also passes.

Checklist

• PR description included
• yarn test passes
• Tests are changed or added
• Relevant documentation is changed or added (and PR referenced)
• New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[danielleadams]

Hey @flozender, thanks for the contribution. What do you think about adding this to the getEditor method instead as the fallback value in the if/else statement?

[flozender]

Ah, yes - that should be better!

[codecov-commenter]

Codecov Report

Merging #9783 (2b97805) into master (fcf9100) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #9783      +/-   ##
==========================================
+ Coverage   53.10%   53.26%   +0.15%     
==========================================
  Files         830      830              
  Lines       45991    45993       +2     
  Branches     9820     9822       +2     
==========================================
+ Hits        24423    24497      +74     
+ Misses      19556    19487      -69     
+ Partials     2012     2009       -3     

Impacted Files	Coverage Δ
...es/amplify-cli/src/init-steps/s0-analyzeProject.ts	69.14% <100.00%> (+29.25%)	⬆️
packages/amplify-cli/src/domain/amplify-toolkit.ts	4.45% <0.00%> (+2.05%)	⬆️
packages/amplify-cli/src/context-extensions.ts	33.75% <0.00%> (+3.75%)	⬆️
...src/extensions/amplify-helpers/editor-selection.ts	96.77% <0.00%> (+6.45%)	⬆️
...ages/amplify-cli/src/init-steps/s1-initFrontend.ts	52.50% <0.00%> (+20.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf9100...2b97805. Read the comment docs.

[danielleadams]

Looks good. Thanks!

[danielleadams]

I was just looking at this test, and it looks like it may be easy to stub the context out and write a unit test. Do you mind adding one? You can add a s0-analyzeProject.test.ts to the same directory as the test I linked.

[flozender]

Sure, I can get that done!

[sachscode]

Could you please use a defaultEditor value from this list https://github.com/aws-amplify/amplify-cli/blob/master/packages/amplify-cli/src/extensions/amplify-helpers/editor-selection.ts#L5-L42 . ( please use the value "vscode" instead of the name "Visual Studio Code" in this test)

[flozender]

Sure! I just want to let you know that I modeled my mockContext.exeInfo object by capturing the attribute during amplify init -y and I found the defaultEditor value to be Visual Studio Code, which is why I used the same.

If you'd still like, please let me know and I can change it to vscode.

[sachscode]

Thanks!
it could be that on Windows the executable is named "Visual Studio Code". no need to change then.

[github-actions]

👋 Hi, this pull request was referenced in the v7.6.23 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.23.