Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map headless auth pw recovery to auto-verified attrs #9786

Merged
merged 4 commits into from
Feb 25, 2022

Conversation

edwardfoyle
Copy link
Member

@edwardfoyle edwardfoyle commented Feb 17, 2022

Description of changes

passwordRecovery options were mapped to autoVerified attributes in the v1 headless schema. the v2 schema instead specified autoVerifiedAttributes explicitly. Additionally, a translation function is added to map incoming v1 requests to the correct v2 request.

Related docs PR: aws-amplify/docs#4046

Issue #, if available

fixes #9756

Description of how you validated changes

Manually, added unit tests, updated e2e tests

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #9786 (d264b0e) into master (0c6508b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d264b0e differs from pull request most recent head 2b7fbc8. Consider uploading reports for the commit 2b7fbc8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9786      +/-   ##
==========================================
+ Coverage   53.00%   53.02%   +0.01%     
==========================================
  Files         830      830              
  Lines       46012    46016       +4     
  Branches     9826     9823       -3     
==========================================
+ Hits        24390    24401      +11     
+ Misses      19604    19597       -7     
  Partials     2018     2018              
Impacted Files Coverage Δ
...vice-walkthrough-types/cognito-user-input-types.ts 100.00% <ø> (ø)
...s/awscloudformation/utils/auth-request-adaptors.ts 52.94% <100.00%> (+6.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c6508b...2b7fbc8. Read the comment docs.

@sachscode sachscode merged commit f8c9100 into aws-amplify:master Feb 25, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

👋 Hi, this pull request was referenced in the v7.6.23 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.23.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headless auth password recovery configuration is mapped to attribute verification
6 participants