Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix notification logic when API resource directory doesn't exist #9796

Merged
merged 1 commit into from
Feb 25, 2022
Merged

fix(cli): fix notification logic when API resource directory doesn't exist #9796

merged 1 commit into from
Feb 25, 2022

Conversation

lazpavel
Copy link
Contributor

Description of changes

  • fix notification logic when API resource directory doesn't exist, for example when api is added with amplify codegen add --apiId {apiId}

Issue #9721

Description of how you validated changes

  • manual testing
    -- amplify init (remove securityEnhancementNotification or init with an older API)
    -- amplify codegen add --apiId {apiId}
    -- amplify push
  • yarn test
  • unit tests added

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sachscode sachscode merged commit 5238264 into aws-amplify:master Feb 25, 2022
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

👋 Hi, this pull request was referenced in the v7.6.23 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
4 participants