fix(graphql): add new open search instance types to the allowed list

[sundersc]

Add OpenSearch instance types to the allowed list.

[cjihrig]

LGTM as a first step to get customers unblocked.

Two notes:

• I'm not sure if we should continue investing time making changes for the v1 transformer.
• If I recall correctly, not all instance types are supported in all regions. I think we need to make the list here contingent on the region. No need to make that change in this PR though.

[danielleadams]

Agree with @cjihrig about not investing in V1, but 👍🏼 .

[codecov-commenter]

Codecov Report

Merging #9834 (6de42b6) into master (fcf9100) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9834   +/-   ##
=======================================
  Coverage   53.10%   53.10%           
=======================================
  Files         830      830           
  Lines       45991    45991           
  Branches     9820     9820           
=======================================
  Hits        24423    24423           
  Misses      19556    19556           
  Partials     2012     2012           

Impacted Files	Coverage Δ
...chable-transformer/src/cdk/create-cfnParameters.ts	100.00% <ø> (ø)
...graphql-elasticsearch-transformer/src/resources.ts	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf9100...6de42b6. Read the comment docs.

[sundersc]

LGTM as a first step to get customers unblocked.

Two notes:

• I'm not sure if we should continue investing time making changes for the v1 transformer.
• If I recall correctly, not all instance types are supported in all regions. I think we need to make the list here contingent on the region. No need to make that change in this PR though.

Agreed. We need to have a map to store the allowed instance types based on the region.
The reason for adding the new instance types to the V1 transformer is to unblock the customer.

[github-actions]

👋 Hi, this pull request was referenced in the v7.6.23 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.23.

[michaetto]

Using new types (i.e. *.search) does not work. Most likely because amplify generates AWS::Elasticsearch::Domain in searchable stack instead AWS::OpenSearchService::Domain.
It would be pretty great to have generated AWS::OpenSearchService::Domain instead, at least under some amplify feature flag in cli.json. We are very close to go to production after hard work and I suppose it could be not easy to change that on production system unless CloudFormation itself allow some seamless migration. Anyway I do elasticsearchVersion = "OpenSearch_1.1" in override.ts, that works with AWS::Elasticsearch::Domain, but only with old instance names, i.e. *.elasticsearch.
@sundersc @cjihrig @danielleadams