fix: set secretsPathAmplfiyAppId on initEnv when function has secrets #9853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfoyle
changed the title
jhockett
approved these changes
Feb 24, 2022
Co-authored-by: John Hockett <jhockett@users.noreply.github.com>
sachscode
approved these changes
Feb 24, 2022
|
👋 Hi, this pull request was referenced in the v7.6.23 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.23. |
github-actions
bot
added
the
referenced-in-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When pulling or checking out a new environment that had a function with secrets configured, the
secretsPathAmplifyAppIdparameter was not being populated inteam-provider-info.json. This causes push failures when the parameter cannot be resolved.The fix updates the function category initEnv logic to copy the appId from
amplify-meta.jsoninto the correct location inteam-provider-info.jsonon init env. This follows the same patter for updating the s3 bucket and key for the function zip asset.Issue #, if available
fixes #8513
Description of how you validated changes
Unit test and manually verified that pulling a project into a new directory and then pushing works.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.