Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove ESM loader to speed up CLI execution #9873

Merged
merged 5 commits into from
Mar 4, 2022

Conversation

jhockett
Copy link
Contributor

@jhockett jhockett commented Feb 28, 2022

Description of changes

Pulled the changes from #9777 and rebased without the botched merge commit.

Credit for these changes belongs to @yuth:

  • Removed ESM loader for NPM CLI installation and update all the packages to be transpiled using
    typescript to covert all ES6 import export statements to commonjs

Issue #, if available

fixes #9309

Description of how you validated changes

yarn test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@akshbhu akshbhu merged commit 46ada02 into aws-amplify:master Mar 4, 2022
@jhockett jhockett deleted the yuth-9777-pr-rebase branch March 4, 2022 18:22
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

👋 Hi, this pull request was referenced in the v7.6.23 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amplify commands take 10+ seconds even for local commands
5 participants