fix: add HostedUIProvider dependency to OAuth Custom Lambda #9878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfoyle
changed the title
jhockett
approved these changes
Mar 1, 2022
| expect( | ||
| cognitoStack | ||
| .oAuthCustomResource!.node!.dependencies!.map((dep: any) => dep.target.logicalId) | ||
| .map(logicalIdToken => /testCognitoStack\.([^\.]+)\.Default/.exec(logicalIdToken)![1]), |
There was a problem hiding this comment.
nit: move this to a named function for readability
sachscode
approved these changes
Mar 1, 2022
| this.oAuthCustomResource.node.addDependency(this.hostedUICustomResourceInputs!.node!.defaultChild!); | ||
| this.oAuthCustomResource.node.addDependency(this.hostedUIProvidersCustomResourceInputs!.node!.defaultChild!); |
There was a problem hiding this comment.
nit:Can we throw an exception here if this.hostedUIProvidersCustomResourceInputs ..defaultChild is falsey
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v7.6.23 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a dependency from the oAuthCustomResource to the hostedUIProvidersCustomResource. The lack of this dependency caused push failures when updating oAuth config with a new provider as the new provider was not added before attempting to update the provider config.
Also removed some unused method parameters and fixed a class name typo.
Issue #, if available
fixes #7388
Description of how you validated changes
Manually verified and added a unit test
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.