Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uibuilder e2e tests #9922

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Fix uibuilder e2e tests #9922

merged 2 commits into from
Mar 7, 2022

Conversation

johnpc
Copy link
Contributor

@johnpc johnpc commented Mar 6, 2022

Description of changes

A failing test is currently blocking the pipeline. This PR fixes the issue by correcting the node_modules path to codegen-ui that was causing the failure.

Issue #, if available

Description of how you validated changes

  • e2e tests now pass
  • ran uibuilder smoke tests on pkg-cli and amplify-dev

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@johnpc johnpc requested a review from a team as a code owner March 6, 2022 16:15
Copy link
Contributor

@sachscode sachscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnpc johnpc merged commit 3e64978 into master Mar 7, 2022
johnpc added a commit that referenced this pull request Mar 7, 2022
* chore: name codegen 1.2

* chore: fix build

Co-authored-by: John Corser <xss@amazon.com>
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

👋 Hi, this pull request was referenced in the v7.6.23 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.23.

@evcodes evcodes deleted the run-e2e/xss/uibuilder-wip-2 branch February 20, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants