fix(graphql): correct searchable instance types

[sundersc]

• This change adds the OpenSearch instance types allowed by cloudformation.
• This reverts the incorrect instance types added in PR fix(graphql): add new open search instance types to the allowed list #9834.
• This is a short term solution to unblock the customers.
• Long term solution is tracked in do not hardcode @searchable instance types in cli  amplify-category-api#71

Fixes #9956

[wvidana]

Why not just remove the allowedValues altogether? Just let CFN define those. That way no one has to maintain the list and people that need to run an older version of the CLI are not stuck with an old list.

[sundersc]

If we remove the allowed values list and someone misspell an instance type, the error would appear at much later time on push resulting in poor DX. We are thinking about using SDK to retrieve the allowed instance types.
https://docs.aws.amazon.com/opensearch-service/latest/developerguide/configuration-api.html#configuration-api-actions-listinstancetypedetails

[codecov-commenter]

Codecov Report

Merging #9973 (43a6398) into master (2f2229c) will decrease coverage by 0.00%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master    aws-amplify/amplify-cli#9973      +/-   ##
==========================================
- Coverage   54.09%   54.08%   -0.01%     
==========================================
  Files         837      837              
  Lines       46374    46376       +2     
  Branches     9890     9891       +1     
==========================================
  Hits        25084    25084              
- Misses      19295    19296       +1     
- Partials     1995     1996       +1     

Impacted Files	Coverage Δ
...chable-transformer/src/cdk/create-cfnParameters.ts	100.00% <ø> (ø)
...rc/graphql-transformer/transform-graphql-schema.ts	15.41% <28.57%> (-0.12%)	⬇️
...graphql-elasticsearch-transformer/src/resources.ts	100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[alharris-at]

One q, otherwise LGTM

[alharris-at]

Is this list the same as the second one down below? can we collapse these down to a single list so we're not duplicating these PRs across two files in the future?

[sundersc]

The list is maintained separately for v1 and v2 transformers. It was intentionally maintained in different places to keep v1 and v2 packages independent of each other. The V1 will eventually go away.

[marcvberg]

LGTM

[phani-srikar]

LGTM!

[ataibarkai]

@sundersc why were all the X.Y.search instance types removed, and only the X.Y.elasticsearch instance types kept?

I believe .elasticsearch instance types are deprecated/outdated, and .search instances are now the preferred ones. E.g. see this document describing the OpenSearch summary of changes that occurred on September 8th 2021:

Instance types in Amazon OpenSearch Service are now in the format <type>.<size>.search—for example, m6g.large.search rather than m6g.large.elasticsearch

That document goes on to say that

"Existing domains will start automatically referring to the new instance types within the API and in the Billing and Cost Management console"

BUT it seems that if this is going to happen, it hasn't yet. .elasticsearch instance types appear to result in outdated deployments which behave different from the latest ones, and which the AWS OpenSearch console prompts you to upgrade.