Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change autocomplete data access property to related model name #1050

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fix: change autocomplete data access property to related model name #1050

merged 1 commit into from
Jul 27, 2023

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Jul 27, 2023

Problem

Autocomplete data property access used property name based on field name

Solution

should be based on related model name

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh requested a review from a team as a code owner July 27, 2023 19:33
@Jshhhh Jshhhh merged commit 694d214 into main Jul 27, 2023
9 checks passed
@Jshhhh Jshhhh deleted the autocomplete-list-relatedmodel branch July 27, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joebuono joebuono joebuono approved these changes

@awinberg-aws awinberg-aws awinberg-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jshhhh @joebuono @awinberg-aws