Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use itemesPerPage for graphql collection query limit #1092

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Sep 2, 2023

Problem

Graphql collection is using a constant page size of 4.

Solution

Use the itemsPerPage component property, fallback to 6

Verification

local app

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh requested a review from a team as a code owner September 2, 2023 03:24
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2023

Codecov Report

Merging #1092 (5da6260) into main (2abdc77) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
- Coverage   93.92%   93.91%   -0.02%     
==========================================
  Files         124      124              
  Lines        5877     5867      -10     
  Branches     1794     1792       -2     
==========================================
- Hits         5520     5510      -10     
  Misses        339      339              
  Partials       18       18              
Files Changed Coverage Δ
...en-ui-react/lib/amplify-ui-renderers/collection.ts 98.07% <ø> (-0.41%) ⬇️
...gen-ui-react/lib/react-studio-template-renderer.ts 93.41% <100.00%> (+0.05%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2abdc77...5da6260. Read the comment docs.

Milan-Shah
Milan-Shah previously approved these changes Sep 5, 2023
awinberg-aws
awinberg-aws previously approved these changes Sep 5, 2023
Copy link
Contributor

@letsbelopez letsbelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jshhhh Jshhhh merged commit 96e6df6 into main Sep 5, 2023
8 of 9 checks passed
@Jshhhh Jshhhh deleted the pagesize branch September 5, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants