Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add datastore to optional dependency #1115

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix: add datastore to optional dependency #1115

merged 1 commit into from
Oct 19, 2023

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Oct 19, 2023

Problem

  • Add aws-ampilify and datastore to optional dependency
  • Remove dependency on amplify auth type

Solution

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh requested a review from a team as a code owner October 19, 2023 21:11
cwoolum
cwoolum previously approved these changes Oct 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1115 (d8c091a) into main (6b2206a) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1115   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files         151      151           
  Lines        6269     6269           
  Branches     1858     1858           
=======================================
  Hits         5877     5877           
  Misses        373      373           
  Partials       19       19           
Files Coverage Δ
...utils-file-functions/hooks/useAuthSignoutAction.ts 90.90% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b2206a...d8c091a. Read the comment docs.

@Jshhhh Jshhhh added bug Something isn't working and removed bug Something isn't working labels Oct 19, 2023
@Jshhhh Jshhhh merged commit 381e0a5 into main Oct 19, 2023
9 checks passed
@Jshhhh Jshhhh deleted the fix-datastore-dep branch October 19, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants