Fix undefined ref errors in {val}ToLinkMap callbacks

[letsbelopez]

Problem

There were errors when trying to reference a value in a callback function where the value was undefined because it was not referencing the correct variable name that was defined in the variable statements part of the components.

Solution

I updated how the reference was created so it is referencing the correct var name.

Additional Notes

In general I worked on simplifying the code of creating the Records value name to make sure it's consistent across each use case that needs that variable name.

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

I updates all the snapshots and went through all the snapshots changes to make sure the references to all the name changes were pointing to the correct variable.

Automated tests

• Unit tests added/updated
• E2E tests added/updated
• N/A - (provide a reason)
• deferred - (provide GitHub issue for tracking)

Housekeeping

• No non-essential console logs
• All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov-commenter]

Codecov Report

Merging #1130 (ece6ef2) into tagged-release/nohooks-patch (6bd127c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                       Coverage Diff                        @@
##           tagged-release/nohooks-patch    #1130      +/-   ##
================================================================
- Coverage                         94.00%   94.00%   -0.01%     
================================================================
  Files                               125      125              
  Lines                              5957     5951       -6     
  Branches                           1822     1817       -5     
================================================================
- Hits                               5600     5594       -6     
  Misses                              339      339              
  Partials                             18       18              

Files	Coverage Δ
.../forms/form-renderer-helper/event-handler-props.ts	99.16% <100.00%> (ø)
...react/lib/forms/form-renderer-helper/form-state.ts	98.94% <100.00%> (ø)
...act/lib/forms/form-renderer-helper/model-values.ts	92.48% <100.00%> (ø)
...act/lib/forms/form-renderer-helper/relationship.ts	93.15% <100.00%> (ø)
...b/forms/form-renderer-helper/render-array-field.ts	100.00% <ø> (ø)
.../codegen-ui-react/lib/forms/react-form-renderer.ts	96.77% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd127c...ece6ef2. Read the comment docs.