Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined reference errors in ToLinkMap callback #1133

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

letsbelopez
Copy link
Contributor

@letsbelopez letsbelopez commented Oct 30, 2023

Problem

Merges in a commit from a patch branch

This one: #1130

Solution

merges in a previously approved commit

Additional Notes

none

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Co-authored-by: David Lopez <lopezbnd@amazon.com>
@letsbelopez letsbelopez requested a review from a team as a code owner October 30, 2023 18:15
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #1133 (4ca6fc2) into main (80194ff) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1133      +/-   ##
==========================================
- Coverage   93.86%   93.85%   -0.01%     
==========================================
  Files         149      149              
  Lines        6110     6104       -6     
  Branches     1839     1834       -5     
==========================================
- Hits         5735     5729       -6     
  Misses        357      357              
  Partials       18       18              
Files Coverage Δ
.../forms/form-renderer-helper/event-handler-props.ts 99.16% <100.00%> (ø)
...react/lib/forms/form-renderer-helper/form-state.ts 98.94% <100.00%> (ø)
...act/lib/forms/form-renderer-helper/model-values.ts 92.48% <100.00%> (ø)
...act/lib/forms/form-renderer-helper/relationship.ts 93.15% <100.00%> (ø)
...b/forms/form-renderer-helper/render-array-field.ts 100.00% <ø> (ø)
.../codegen-ui-react/lib/forms/react-form-renderer.ts 97.72% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80194ff...4ca6fc2. Read the comment docs.

@letsbelopez letsbelopez changed the title fix: undefined reference errors in ToLinkMap callback (#1130) fix: undefined reference errors in ToLinkMap callback Oct 30, 2023
@letsbelopez letsbelopez merged commit ac1904c into main Oct 30, 2023
9 checks passed
@letsbelopez letsbelopez deleted the merge-patches-to-main branch October 30, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants