Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move amplify js v6 to latest #1135

Merged
merged 12 commits into from
Nov 16, 2023
Merged

feat: move amplify js v6 to latest #1135

merged 12 commits into from
Nov 16, 2023

Conversation

letsbelopez
Copy link
Contributor

Problem

Amplify JS UI React just moved v6 to latest and we need to render v6 code as latest.

Solution

Update v6 feature flag

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason) feature flag update only. We already have a bunch of unit tests that tests this feature flag being on and off.
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@letsbelopez letsbelopez requested a review from a team as a code owner November 15, 2023 18:17
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Merging #1135 (58a159b) into main (a7c9f73) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1135   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files         149      149           
  Lines        6104     6104           
  Branches     1834     1834           
=======================================
  Hits         5729     5729           
  Misses        357      357           
  Partials       18       18           
Files Coverage Δ
...egen-ui-react/lib/helpers/amplify-js-versioning.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c9f73...58a159b. Read the comment docs.

@Milan-Shah Milan-Shah self-requested a review November 16, 2023 18:20
Milan-Shah
Milan-Shah previously approved these changes Nov 16, 2023
@letsbelopez letsbelopez merged commit 69ece2f into main Nov 16, 2023
10 checks passed
@letsbelopez letsbelopez deleted the set-v6-as-latest branch November 16, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants