Add import mappings to non-dynamic, and correct EscapeHatchProps import type. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #277 +/- ##
===========================================
+ Coverage 89.25% 89.48% +0.22%
===========================================
Files 32 34 +2
Lines 1191 1217 +26
Branches 271 273 +2
===========================================
+ Hits 1063 1089 +26
Misses 125 125
Partials 3 3
Continue to review full report at Codecov.
|
dpilch
approved these changes
Dec 6, 2021
dpilch
pushed a commit
that referenced
this pull request
Dec 6, 2021
…s import type. (#277) * feat: add support for developing on windows * chore: add import mapping for static import types * fix: correct EscapeHatchProps import, and ensure it works with tsx integ tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Included in this PR is the update to support Windows just since that's what I'm developing on, but that's covered in this PR #276
Adding enum values for non-dynamic imports, and ensuring there's a single mapping location, so updates or changes downstream are safer to apply.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.