fix: proper use of type from ui builder backend #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
==========================================
- Coverage 89.63% 89.56% -0.07%
==========================================
Files 36 36
Lines 1244 1246 +2
Branches 278 278
==========================================
+ Hits 1115 1116 +1
- Misses 126 127 +1
Partials 3 3
Continue to review full report at Codecov.
|
|
lgtm, but lets also get a review from @alharris-at/@dpilch on this pr as I am not too familiar with this section of the code |
|
also, I think you might want to push this pr to develop instead of main. We generally push changes into develop first, and merge into main when we do the release |
dpilch
requested changes
Dec 27, 2021
| // object, array, and null | ||
| case 'object': | ||
| return factory.createJsxExpression(undefined, jsonToLiteral(parsedValue)); | ||
| default: |
There was a problem hiding this comment.
Can you add test cases for these scenarios? Type mismatch case as well.
kpranoto-aws
force-pushed
the
proper-ui-builder-props-type
branch
from
018f0e5
to
d134a65
Compare
kpranoto-aws
force-pushed
the
proper-ui-builder-props-type
branch
from
d134a65
to
179ef02
Compare
dpilch
approved these changes
Dec 28, 2021
This was referenced Feb 17, 2022
Closed
Merged
alharris-at
pushed a commit
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
JS types specified in the type prop is in lowercase, and all of the values pulled from the backend are string literals. Updating the function to take those into account