feat: expose renderThemeJson method to generate themes in studio ui #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alharris-at
changed the title
dpilch
approved these changes
Jan 21, 2022
alharris-at
added a commit
that referenced
this pull request
Jan 21, 2022
alharris-at
added a commit
that referenced
this pull request
Jan 21, 2022
alharris-at
added a commit
that referenced
this pull request
Jan 24, 2022
* chore: upgrade to follow-redirects@1.14.7 (#337) resolves dependabot warning * feat: expose renderThemeJson method to generating themes in studio ui (#340) (#346) * feat: implement auth attributes directly at the child level (#344) Moved auth attribute usage to child components to avoid creating top-level auth statements. Co-authored-by: Dane Pilcher <dppilche@amazon.com> Co-authored-by: Al Harris <91494052+alharris-at@users.noreply.github.com>
This was referenced Feb 17, 2022
Closed
Merged
alharris-at
added a commit
that referenced
this pull request
Feb 24, 2022
alharris-at
added a commit
that referenced
this pull request
Feb 24, 2022
* chore: upgrade to follow-redirects@1.14.7 (#337) resolves dependabot warning * feat: expose renderThemeJson method to generating themes in studio ui (#340) (#346) * feat: implement auth attributes directly at the child level (#344) Moved auth attribute usage to child components to avoid creating top-level auth statements. Co-authored-by: Dane Pilcher <dppilche@amazon.com> Co-authored-by: Al Harris <91494052+alharris-at@users.noreply.github.com>
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
* chore: upgrade to follow-redirects@1.14.7 (#337) resolves dependabot warning * feat: expose renderThemeJson method to generating themes in studio ui (#340) (#346) * feat: implement auth attributes directly at the child level (#344) Moved auth attribute usage to child components to avoid creating top-level auth statements. Co-authored-by: Dane Pilcher <dppilche@amazon.com> Co-authored-by: Al Harris <91494052+alharris-at@users.noreply.github.com>
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
* chore: upgrade to follow-redirects@1.14.7 (#337) resolves dependabot warning * feat: expose renderThemeJson method to generating themes in studio ui (#340) (#346) * feat: implement auth attributes directly at the child level (#344) Moved auth attribute usage to child components to avoid creating top-level auth statements. Co-authored-by: Dane Pilcher <dppilche@amazon.com> Co-authored-by: Al Harris <91494052+alharris-at@users.noreply.github.com>
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
* chore: upgrade to follow-redirects@1.14.7 (#337) resolves dependabot warning * feat: expose renderThemeJson method to generating themes in studio ui (#340) (#346) * feat: implement auth attributes directly at the child level (#344) Moved auth attribute usage to child components to avoid creating top-level auth statements. Co-authored-by: Dane Pilcher <dppilche@amazon.com> Co-authored-by: Al Harris <91494052+alharris-at@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#338
Description of changes:
Expose a new method from the theme renderer called
renderThemeJsonwhich provides only the formatted json value.,Also moved theme render snapshot tests out of the suite that runs component tests, just for a little separation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.