Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add special case for fields and model action parameters #358

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

dpilch
Copy link
Contributor

@dpilch dpilch commented Jan 25, 2022

Adds stub for DataStoreCreateItem action but does not fully implement

@dpilch dpilch requested a review from a team January 25, 2022 18:46
Copy link
Contributor

@dhandsar-aws dhandsar-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, tests are failing I'm sure you're aware & already looking into it

@alharris-at alharris-at changed the base branch from feature/workflow-binding to tagged-release/q1-release January 25, 2022 20:37
@codecov-commenter
Copy link

Codecov Report

Merging #358 (e323c5b) into tagged-release/q1-release (2a64978) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           tagged-release/q1-release     #358      +/-   ##
=============================================================
+ Coverage                      93.07%   93.13%   +0.05%     
=============================================================
  Files                             37       37              
  Lines                           1416     1427      +11     
  Branches                         314      316       +2     
=============================================================
+ Hits                            1318     1329      +11     
  Misses                            96       96              
  Partials                           2        2              
Impacted Files Coverage Δ
packages/codegen-ui-react/lib/action.ts 78.18% <100.00%> (+5.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a64978...e323c5b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants