Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing import statement, and correct controlled component s… #374

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

alharris-at
Copy link
Contributor

@alharris-at alharris-at commented Feb 1, 2022

…tate tracking

Issue #, if available:
N/A

Description of changes:

  • Adding Missing import statement for state hook.
  • Use event input for controlled component onChange, rather than passing full payload back.
  • Move use*Action to managed imports, rather than just importing inline.
  • Remove erroneous properties declaration for datastore test cases (were being overwritten by a subsequent declaration.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alharris-at alharris-at requested a review from a team February 1, 2022 02:07
@codecov-commenter
Copy link

Codecov Report

Merging #374 (b98a8f4) into tagged-release/q1-release (c62df4d) will increase coverage by 0.05%.
The diff coverage is 92.59%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           tagged-release/q1-release     #374      +/-   ##
=============================================================
+ Coverage                      93.10%   93.16%   +0.05%     
=============================================================
  Files                             40       40              
  Lines                           1566     1579      +13     
  Branches                         339      340       +1     
=============================================================
+ Hits                            1458     1471      +13     
  Misses                           106      106              
  Partials                           2        2              
Impacted Files Coverage Δ
...s/codegen-ui-react/lib/react-component-renderer.ts 78.26% <33.33%> (ø)
...ges/codegen-ui-react/lib/imports/import-mapping.ts 100.00% <100.00%> (ø)
...eact/lib/react-component-with-children-renderer.ts 95.00% <100.00%> (ø)
...gen-ui-react/lib/react-studio-template-renderer.ts 91.27% <100.00%> (ø)
packages/codegen-ui-react/lib/workflow/action.ts 94.91% <100.00%> (ø)
packages/codegen-ui-react/lib/workflow/mutation.ts 91.93% <100.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62df4d...b98a8f4. Read the comment docs.

@alharris-at alharris-at merged commit 4cb6591 into tagged-release/q1-release Feb 1, 2022
@alharris-at alharris-at deleted the workflow/mutation-fixes branch February 1, 2022 16:39
@dpilch dpilch mentioned this pull request Feb 24, 2022
@alharris-at alharris-at mentioned this pull request Feb 24, 2022
alharris-at added a commit that referenced this pull request Feb 24, 2022
alharris-at added a commit that referenced this pull request Feb 25, 2022
alharris-at added a commit that referenced this pull request Feb 25, 2022
alharris-at added a commit that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants