feat: allow objects to be passed into properties to support paths in … #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## tagged-release/q1-release #384 +/- ##
=============================================================
- Coverage 93.17% 93.06% -0.11%
=============================================================
Files 43 43
Lines 1626 1630 +4
Branches 347 349 +2
=============================================================
+ Hits 1515 1517 +2
- Misses 109 111 +2
Partials 2 2
Continue to review full report at Codecov.
|
dpilch
approved these changes
Feb 7, 2022
This was referenced Feb 17, 2022
Closed
Merged
alharris-at
added a commit
that referenced
this pull request
Feb 24, 2022
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…icons
Issue #, if available:
N/A
Description of changes:
Adding an example file for an icon support
pathsas a prop, which is itself a javascript object. This required a minor update to the translation layer for props.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.