fix: add override for stepper and slider controlled change events #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## tagged-release/q1-release #389 +/- ##
=============================================================
+ Coverage 93.64% 93.70% +0.06%
=============================================================
Files 43 43
Lines 1636 1653 +17
Branches 352 356 +4
=============================================================
+ Hits 1532 1549 +17
Misses 102 102
Partials 2 2
Continue to review full report at Codecov.
|
alharris-at
force-pushed
the
workflow/syntheticChangeProps
branch
from
40787f3
to
39c31a0
Compare
alharris-at
changed the title
dpilch
approved these changes
Feb 9, 2022
This was referenced Feb 17, 2022
Closed
Merged
alharris-at
added a commit
that referenced
this pull request
Feb 24, 2022
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
alharris-at
added a commit
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Stepper primitive takes an onStepChange callback, rather than onChange, and issues a raw number rather than a full SyntheticEvent, adding support for synthetic event names, as well as implementations which are based on the primitive type.
Also updated the SliderField to use the numeric callback, though w/ the name onChange per UI docs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.