Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address reserved keywords in bindings #431

Merged
merged 2 commits into from
Feb 28, 2022
Merged

fix: address reserved keywords in bindings #431

merged 2 commits into from
Feb 28, 2022

Conversation

alharris-at
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:
For full list of reserved keywords, refer to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#keywords

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alharris-at alharris-at changed the base branch from tagged-release/q1-release to develop February 25, 2022 00:38
@dpilch dpilch changed the base branch from develop to main February 25, 2022 15:21
@dpilch dpilch force-pushed the bug/class-binding branch 2 times, most recently from 1df9bf2 to 4b2412a Compare February 25, 2022 18:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #431 (a209dc6) into main (d42d103) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   93.49%   93.51%   +0.02%     
==========================================
  Files          46       47       +1     
  Lines        1798     1804       +6     
  Branches      392      394       +2     
==========================================
+ Hits         1681     1687       +6     
  Misses        113      113              
  Partials        4        4              
Impacted Files Coverage Δ
packages/codegen-ui-react/lib/keywords.ts 100.00% <100.00%> (ø)
...egen-ui-react/lib/react-component-render-helper.ts 90.44% <100.00%> (+0.09%) ⬆️
...gen-ui-react/lib/react-studio-template-renderer.ts 91.56% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42d103...a209dc6. Read the comment docs.

@dpilch dpilch marked this pull request as ready for review February 25, 2022 21:28
@dpilch dpilch requested a review from a team February 25, 2022 21:28
Copy link
Contributor Author

@alharris-at alharris-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, can't approve my own PR here since I'd initially opened, but LGTM.

@dpilch dpilch merged commit fd0a2a5 into main Feb 28, 2022
@dpilch dpilch deleted the bug/class-binding branch February 28, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants