fix: remove hook from conditional statement #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #455 +/- ##
=======================================
Coverage 93.52% 93.53%
=======================================
Files 48 48
Lines 1808 1809 +1
Branches 394 394
=======================================
+ Hits 1691 1692 +1
Misses 113 113
Partials 4 4
Continue to review full report at Codecov.
|
alharris-at
approved these changes
Mar 9, 2022
|
Looks good, I expect the functional tests should pass once you pull/rebase Hein's PR she pushed this morning. |
SwaySway
force-pushed
the
nonConditionalHookFix
branch
from
01d5d64
to
9f58820
Compare
rebased latest commit with Hein's test fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.