Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rev required minimum version of ui-react #462

Merged
merged 1 commit into from
Apr 13, 2022
Merged

feat: rev required minimum version of ui-react #462

merged 1 commit into from
Apr 13, 2022

Conversation

hein-j
Copy link
Contributor

@hein-j hein-j commented Apr 13, 2022

Description of changes:
Rev minimum version of ui-react to 12.13.0 (see change log here), which has type casting for DataStore hooks.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hein-j hein-j requested a review from a team as a code owner April 13, 2022 17:51
@codecov-commenter
Copy link

Codecov Report

Merging #462 (b49d9ca) into main (79953c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files          48       48           
  Lines        1818     1818           
  Branches      396      396           
=======================================
  Hits         1702     1702           
  Misses        112      112           
  Partials        4        4           
Impacted Files Coverage Δ
...ui-react/lib/react-required-dependency-provider.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79953c5...b49d9ca. Read the comment docs.

supportedSemVerPattern: '^2.10.3',
reason: 'Required to leverage amplify ui primitives, and studio component helper functions.',
supportedSemVerPattern: '^2.13.0',
reason: 'Required to leverage type casting in DataStore hooks.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this reason is a subset of using studio component helper functions

Copy link
Contributor

@Jshhhh Jshhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hein-j hein-j merged commit d33f873 into main Apr 13, 2022
@hein-j hein-j deleted the version branch April 13, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants